Problem: Setting the "Archival institution upload limits" to Disabled in the settings does not actually disable per institution upload limits

[fiver-watson]

Current Behavior

This was discovered on a client production site, and took some time to figure out.

Steps to reproduce the behavior

1. In config/app.yml, set the upload_limit value to -1 (i.e. unlimited)
2. In a repository view page, use the digital object uploads widget to set a limit - in the client site, it was 25GB
3. In Admin > Settings > Uploads, set the "Default archival institution upload limit (GB)" to -1 (i.e. unlimited)
4. Just above that, set the "Archival institution upload limits" setting to Disabled
5. Save
6. Make sure that you have more tdigital objects than the limit set in step 2
7. Go to a description linked to that repository, and click "Link digital object"

Resulting error

• The DO limit set in step 2 is still enforced
• The upload widget is not in fact disabled, despite the widget being disabled and the per-repo default upload limit set to -1

Expected Behavior

When the Institutional upload limit is Disabled, then:

• The default institutional upload limit setting should also be set to -1 and disabled (ideally with a tooltip indicating the relation to the other setting), and
• No upload limit per institution should be enforced

Otherwise:

• A very clear warning should appear with the setting clarifying that this merely prevents the DISPLAY of the widget (which may help page load times, as AtoM will not try to calculate the current used space when loading a repo view page), and will NOT actually disable the functionality of the widget.

Possible Solution

Either much clearer documentation AND in-application help text, OR ensuing that disabling the widget actually disables the per-institution upload limit and all associated checks.

Context and Notes

No response

Version used

2.8.2 - 193

Operating System and version

Ubuntu 20.04

Default installation culture

en

PHP version

PHP 7.4

Contact details

No response