Workflow SA / RBAC doesn't render namespace when .Values.singleNamespace is set to true

[wobu]

Describe the bug

When using singleNamespace: true every k8s resource is supposed to be installed within the namespace.
For the components workflow-controller and workflow-server the namespace of the helm release is explicitly rendered in the k8s yaml definitions except for the workflow rbac and service account

see:

argo-helm/charts/argo-workflows/templates/controller/workflow-sa.yaml

Line 2 in b583d77

{{- range $namespace := or .Values.singleNamespace false | ternary (list "") (append .Values.controller.workflowNamespaces (coalesce .Values.workflow.namespace (include "argo-workflows.namespace" .)) | uniq) }}

the default namespace values of coalesce .Values.workflow.namespace (include "argo-workflows.namespace" .)) is only added to the 2nd case of the ternary when singleNamespace option isn't set to true

i propose to add the coalesce fallback to the whole expression.

files affected:

• workflow-sa.yaml
• workflow-rb.yaml
• workflow-role.yaml

Related helm chart

argo-workflows

Helm chart version

0.41.1

To Reproduce

1. set .Values.singleNamespace: true
2. Render helm chart with namespace like helm -n test_namespace template argo-workflows argo/argo-workflows

Expected behavior

namespace of workflow sa and rbac should be explicitly set when using singleNamspace: true

Screenshots

No response

Additional context

No response