Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to create multiple workflow ServiceAccount resources per namespace #2596

Closed
jdaftari-confluent opened this issue Mar 21, 2024 · 1 comment

Comments

@jdaftari-confluent
Copy link

jdaftari-confluent commented Mar 21, 2024

Is your feature request related to a problem?

Currently, we have the ability to create a single workflow ServiceAccount which can be installed in multiple namespaces. This workflow has the same name, annotations, etc. The following is a minimal config for achieving this

workflow:
  serviceAccount:
    create: true
    name: "argo-workflow"
  rbac:
    create: true
controller:
  workflowNamespaces:
    - default
    - foo
    - bar

However, we don't have the ability to create multiple ServiceAccount resources within a single namespace or multiple namespaces. Using a separate ServiceAccount (with separate annotations) gives ability to provide granular permissions.

Related helm chart

argo-workflows

Describe the solution you'd like

An example config may look like this

workflow:
  serviceAccounts:
    - name: "argo-workflow-read"
      rbac:
        create: true
      namespaces: ["foo", "bar"]
      annotations:
        "eks.amazonaws.com/role-arn": "arn:aws:iam::123456789012:role/argo-workflow-read"
    - name: "argo-workflow-update"
      rbac:
        create: true
      namespaces: ["bar"]
      annotations:
        "eks.amazonaws.com/role-arn": "arn:aws:iam::123456789012:role/argo-workflow-update"

This would mean that we deprecate workflow.serviceAccount, workflow.rbac and controller.workflowNamespaces config parameters.

Describe alternatives you've considered

No response

Additional context

No response

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants