Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change clusterCredentials type to map #2592

Closed
nbarrientos opened this issue Mar 20, 2024 · 1 comment · Fixed by #2648
Closed

Change clusterCredentials type to map #2592

nbarrientos opened this issue Mar 20, 2024 · 1 comment · Fixed by #2648
Labels
argo-cd enhancement New feature or request

Comments

@nbarrientos
Copy link
Contributor

Is your feature request related to a problem?

Helm does not support merging arrays so it's not possible to have for instance cluster declarations in separate "values" files (in view of encrypting them with different keys).

configs:
  clusterCredentials:
    - name: my-cluster
      server: https://example.com:6443
      config:
        bearerToken: "foo"
        tlsClientConfig:
          insecure: false
          caData: "bar"

Related helm chart

argo-cd

Describe the solution you'd like

Declare clusters with the same syntax as configs.repositories:

configs:
  clusterCredentials:
    my-cluster:
      server: https://example.com:6443
      config:
        bearerToken: "foo"
        tlsClientConfig:
          insecure: false
          caData: "bar"

as each cluster is represented by a key in the map configs.clusterCredentials it'd be possible for Helm to merge multiple clusters declared in separate values files.

Describe alternatives you've considered

No response

Additional context

No response

@nbarrientos nbarrientos added the enhancement New feature or request label Mar 20, 2024
@nbarrientos
Copy link
Contributor Author

Any chance before we fork locally? 🙏

nbarrientos added a commit to cerndb/argo-helm that referenced this issue Apr 19, 2024
nbarrientos added a commit to cerndb/argo-helm that referenced this issue Apr 19, 2024
So it can be merged with values coming from different sources.

Closes argoproj#2592

Signed-off-by: Nacho Barrientos <[email protected]>
nbarrientos added a commit to cerndb/argo-helm that referenced this issue Apr 29, 2024
So it can be merged with values coming from different sources.

Closes argoproj#2592

Signed-off-by: Nacho Barrientos <[email protected]>
nbarrientos added a commit to cerndb/argo-helm that referenced this issue Apr 29, 2024
So it can be merged with values coming from different sources.

Closes argoproj#2592

Signed-off-by: Nacho Barrientos <[email protected]>
nbarrientos added a commit to cerndb/argo-helm that referenced this issue Apr 29, 2024
So it can be merged with values coming from different sources.

Closes argoproj#2592

Signed-off-by: Nacho Barrientos <[email protected]>
nbarrientos added a commit to cerndb/argo-helm that referenced this issue Apr 29, 2024
So it can be merged with values coming from different sources.

Closes argoproj#2592

Signed-off-by: Nacho Barrientos <[email protected]>
nbarrientos added a commit to cerndb/argo-helm that referenced this issue May 27, 2024
So it can be merged with values coming from different sources.

Closes argoproj#2592

Signed-off-by: Nacho Barrientos <[email protected]>
nbarrientos added a commit to cerndb/argo-helm that referenced this issue May 28, 2024
So it can be merged with values coming from different sources.

Closes argoproj#2592

Signed-off-by: Nacho Barrientos <[email protected]>
nbarrientos added a commit to cerndb/argo-helm that referenced this issue May 28, 2024
So it can be merged with values coming from different sources.

Closes argoproj#2592

Signed-off-by: Nacho Barrientos <[email protected]>
mbevc1 pushed a commit that referenced this issue May 28, 2024
So it can be merged with values coming from different sources.

Closes #2592

Signed-off-by: Nacho Barrientos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants