Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable writing k8s events #18205

Open
tooptoop4 opened this issue May 14, 2024 · 5 comments · May be fixed by #18441
Open

Option to disable writing k8s events #18205

tooptoop4 opened this issue May 14, 2024 · 5 comments · May be fixed by #18441
Assignees
@Jack-R-lantern
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tooptoop4
Copy link

Summary

Environment variable/config to stop writing k8s events

Motivation

When i want to stop etcd filling up

Proposal

These parts of the code are writing k8s events which end up being stored in etcd:

argo-cd/util/argo/audit_logger.go

Lines 40 to 46 in 2162aaf

EventReasonStatusRefreshed = "StatusRefreshed"
EventReasonResourceCreated = "ResourceCreated"
EventReasonResourceUpdated = "ResourceUpdated"
EventReasonResourceDeleted = "ResourceDeleted"
EventReasonResourceActionRan = "ResourceActionRan"
EventReasonOperationStarted = "OperationStarted"
EventReasonOperationCompleted = "OperationCompleted"

argo-cd/server/application/application.go

Line 1901 in 2162aaf

s.logAppEvent(a, ctx, argo.EventReasonOperationStarted, reason)

argo-cd/docs/operator-manual/security.md

Line 190 in 2162aaf

$ kubectl get events

@tooptoop4 tooptoop4 added the enhancement New feature or request label May 14, 2024
@rumstead
Copy link
Contributor

related #10529

@tooptoop4 tooptoop4 mentioned this issue May 21, 2024
Closed
@pasha-codefresh pasha-codefresh added the good first issue Good for newcomers label May 22, 2024
@Jack-R-lantern
Copy link
Contributor

Jack-R-lantern commented May 28, 2024 •
edited

@pasha-codefresh I would like to work on this issue, can you assign me an issue?

@pasha-codefresh
Copy link
Member

Thank you @Jack-R-lantern

@Jack-R-lantern Jack-R-lantern linked a pull request May 29, 2024 that will close this issue
Open
14 tasks
@Jack-R-lantern
Copy link
Contributor

@tooptoop4
Is it better to implement logging on/off based on the reason for the event?
Or should we implement on/off based on the kind?

@tooptoop4
Copy link
Author

i was interested in turning off all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jack-R-lantern Jack-R-lantern

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: option to disable writing k8s events(#18205) Jack-R-lantern/argo-cd
4 participants
@tooptoop4 @rumstead @pasha-codefresh @Jack-R-lantern