Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Make laravel-azure-storage a suggested dependency #2570

Open
Tofandel opened this issue Apr 2, 2024 · 3 comments
Open

[4.x] Make laravel-azure-storage a suggested dependency #2570

Tofandel opened this issue Apr 2, 2024 · 3 comments

Comments

@Tofandel
Copy link
Contributor

Tofandel commented Apr 2, 2024

Description

matthewbdaly/laravel-azure-storage is present in require of composer but not used anywhere from what I see

It also triggers a warning
Package matthewbdaly/laravel-azure-storage is abandoned, you should avoid using it. Use https://github.com/Azure-OSS/azure-storage-php instead.

@ifox
Copy link
Member

ifox commented May 24, 2024

Hi @Tofandel this dependency is actually used when using azure in MEDIA_LIBRARY_ENDPOINT_TYPE and/or FILE_LIBRARY_ENDPOINT_TYPE.

Unfortunately it looks like efforts to maintain this integration for Laravel have stalled since Microsoft deprecated their SDK.

We could remove the dependency and document installation or even install it dynamically if the azure type is used for now.

@Tofandel
Copy link
Contributor Author

Then yes it should be in suggest dependencies and documented in the configuration of MEDIA_LIBRARY_ENDPOINT_TYPE and also using the new recommended lib now, removing it from dependencies now has to be done in v4 though (but changing it to a newer one can be done in v3)

@ifox
Copy link
Member

ifox commented May 30, 2024

I agree, but unfortunately the recommended library has no release yet.

@ifox ifox changed the title Unused deprecated dependency in composer.json [4.x] Make laravel-azure-storage a suggested dependency May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants