Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow dynamic urls #114

Open
fruitl00p opened this issue Mar 6, 2024 · 2 comments
Open

Feature request: allow dynamic urls #114

fruitl00p opened this issue Mar 6, 2024 · 2 comments

Comments

@fruitl00p
Copy link
Contributor

Currently we're bulding a static version of the storybook (blast:publish) and including that in a docker image to be deployed to various urls... Thus the STORYBOOK_SERVER_URL still includes the storybook_preview (which is weird as i'd like to have a static build of the entire storybook)

So what am i doing wrong? Is this something inside storybook or in the combination of blast and storybook ?

@ifox
Copy link
Member

ifox commented Mar 6, 2024

Blast is using Storybook Server, so that's completely expected. If you are not using story controls, I understand why you'd think that it could just generate everything statically for publishing, but the moment you have something dynamic in a story, Blast is making a request to your Laravel application to get that Blade view rendered with the new parameters. So technically if you wanted all that to work statically, you would need to generate the static response for every single permutation of your stories arguments. Hope that makes sense.

@fruitl00p
Copy link
Contributor Author

Not really. I can understand that it still requires some backend processing, but using relative urls would be enough. As we publish the 'static' files during CI/CD into a docker image the actual deployment of the resulting containers determine the full-url... Is there any way to allow relative URL's to be enough?
(its not like we're deploying to HTML only server environment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants