Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiview Support #446

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Multiview Support #446

wants to merge 27 commits into from

Conversation

ardera
Copy link
Owner

@ardera ardera commented Sep 17, 2024

No description provided.

- add codechecker workflow
- enable `-pedantic`
- fix a lot of warnings
- only report error from `gbm_surface_create_with_modifiers` if `gbm_surface_create` fails too
- add multidisplay plugin stub
- make compositor multiview capable
  - use klib (khash) to implement the
    view id -> window mapping
- split drmdev into drm_resources and drmdev
  - drmdev: (mostly) non-stateful part. Basically a
    better wrapper around a drm fd. mt-safe
  - drm_resources: the DRM state / resources.
    is stateful, but does not update itself.
    To keep it in sync with kernel state,
    one needs to listen to kernel events with
    drm_monitor and call drm_resources_update.
  - drm_resources is not mt-safe and only
    supposed to be used on a single thread.
  - add a bunch of QoL stuff to drm_resources
- use evloop as platform and raster thread
  event loop (mt-safe wrapper around sd-event)
- add own mutex type & fns with thread safety annotations
- generally refactor flutter-pi.c and drmdev
- fix function mixup in sentry plugin
Call the release callback for the commit that is no longer visible on screen before calling the scanout callback.

The scanout callback might already start a new frame, and the release callback releases some resources that could be useful for building the new frame, so this helps avoid resource exhaustion.
not available everywhere (debian bullseye)
for sd_event_source_disable_unref
@eu-erwin
Copy link

eu-erwin commented Oct 8, 2024

@ardera

does this PR support multi display? I would like to help on testing, I have DSI and HDMI displays.

is this run on single flutter engine or multiple engines?

@vanlooverenkoen
Copy link

@ardera can you maybe add a video or a linked ticket, in case we want to test this so we know what to actually test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants