Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing snapshot image error after installing cypress-terminal-report #145

Closed
ritchieanesco opened this issue May 18, 2022 · 2 comments
Closed
Labels
wontfix This will not be worked on

Comments

@ritchieanesco
Copy link

ritchieanesco commented May 18, 2022

First off, great plugin! Has helped our project debug issues with request payload and authentication tokens!

After installing cypress-terminal-report, we've noticed that cypress-snapshot-plugin no longer opens the modal to display changes in snapshot. It looks to have an impact on snapshots feature in cypress, as I'm seeing "snapshot is missing" in the command log.

Expected Behavior

When a change occurs in the layout, a "snapshot comparison" link is available in the command log. On click of "snapshot comparison" a modal appears displaying the area of the layout that has been changed.

Actual Behavior

When a change occurs in the layout, a "snapshot comparison" link is available in the command log. On click of "snapshot comparison" nothing happens.

Would you please advise us on how we can address this issue?

Screenshot

Screen Shot 2022-05-19 at 9 26 51 am

@ritchieanesco ritchieanesco changed the title Terminal report hijacks cypress-snapshot-plugin click event Missing snapshot image error after installing cypress-terminal-report May 19, 2022
@archfz
Copy link
Owner

archfz commented May 25, 2022

Hmm. I am not sure if it is related or not. But it might be. Either way this is an issue in cypress-snapshot-plugin. Quite the coincidence but I also use this plugin on one of my projects. Aaaaand actually I created a PR in that plugin to fix this:

meinaart/cypress-plugin-snapshots#207

I can only recommend installing patch-package and adding the contents of that PR as a patch. The maintainers of that project don't care about it.

You might be interested in this one as well. meinaart/cypress-plugin-snapshots#209

@ritchieanesco
Copy link
Author

Thanks for getting back to @archfz. Will take a look.

@archfz archfz closed this as completed Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants