Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PagedList has no public constructor #116

Open
kevingy opened this issue Oct 5, 2019 · 4 comments
Open

PagedList has no public constructor #116

kevingy opened this issue Oct 5, 2019 · 4 comments

Comments

@kevingy
Copy link
Contributor

kevingy commented Oct 5, 2019

Is there any reason that PagedList has no public constructor? All of the constuctors are currently internal. As a result, I can't unit test code that returns a PagedList because I can't create a PagedList to return in the unit test.

I propose exposing a public constructor - or a static class that will return a new PagedList that is modifyable outside of UnitOfWork, similar to the Empty() method.

I'll even do the work and submit a pull request, if this seems reasonable. (I think it does.)

@rigofunc
Copy link
Member

I'm agree with you, can U PR for this?

@kevingy
Copy link
Contributor Author

kevingy commented Dec 14, 2019

Yes. I will create it as soon as possible.

@NafezDeeb
Copy link

any update on this issue?

@nappinglady
Copy link

nappinglady commented Dec 14, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants