Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statically link binaries and remove debug information #1615

Merged
merged 1 commit into from
May 22, 2024
Merged

Statically link binaries and remove debug information #1615

merged 1 commit into from
May 22, 2024

Conversation

pjbgf
Copy link
Contributor

@pjbgf pjbgf commented May 15, 2024 •
edited

Statically link the generated binaries as to avoid issues when the application is linked to a different GLIBC version than the one available when kube-bench is used.
This also removes the debug information, resulting on the assets being half the current size (~13MB each instead of ~25MB).

Fixes #1592.

@CLAassistant
Copy link

CLAassistant commented May 15, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@pjbgf pjbgf mentioned this pull request May 15, 2024
Closed
1 task
@pjbgf
Copy link
Contributor Author

pjbgf commented May 20, 2024

The lint error is orthogonal to the changes:

$ golangci-lint run
WARN The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
ERRO [linters_context] deadcode: This linter is fully inactivated: it will not produce any reports.
ERRO [linters_context] varcheck: This linter is fully inactivated: it will not produce any reports.

Should I remove the two deprecated linters as part of this PR?

@chen-keinan
Copy link
Collaborator

@pjbgf please rebase with upstream to fix the lint issue.

mozillazg
mozillazg approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution!

@chen-keinan chen-keinan merged commit 0f8dfaf into aquasecurity:main May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozillazg mozillazg mozillazg approved these changes

@chen-keinan chen-keinan chen-keinan approved these changes

@andypitcher andypitcher andypitcher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing GLIBC dependency in binary version 0.7.1+
5 participants
@pjbgf @CLAassistant @chen-keinan @mozillazg @andypitcher