Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Krane can not be installed using FluxCD #277

Open
nekwar opened this issue Nov 23, 2022 · 1 comment
Open

[BUG] Krane can not be installed using FluxCD #277

nekwar opened this issue Nov 23, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@nekwar
Copy link

nekwar commented Nov 23, 2022

Short issue description

It's not possible to install Krane using FluxCD solution because of the following issue:

Helm install failed: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors: line 51: mapping key "restartPolicy" already defined at line 49

Interesting thing is that it works fine with just helm binary.

Krane version: 0.1.1
OS (Linux/Mac/Windows..): MacOS
Kubernetes version: 1.22
Kubernetes distribution (e.g. GKE, EKS, ...): MKE (Mirantis Kubernetes Engine)

How can we reproduce the issue?

Install FluxCD to your cluster, then add two manifests to FluxCD:

apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
  name: krane
  namespace: krane
spec:
  interval: 5m
  chart:
    spec:
      chart: krane
      version: 0.1.1
      sourceRef:
        kind: HelmRepository
        name: krane-chart
        namespace: krane
      interval: 5m
apiVersion: source.toolkit.fluxcd.io/v1beta1
kind: HelmRepository
metadata:
  name: krane-chart
  namespace: krane
spec:
  interval: 1h
  url: https://appvia.github.io/krane
  timeout: 3m

Suggestions on how to fix the issue

The reason for that is duplicate restartPolicy option in RedisGraph deployment manifest on lines https://github.com/appvia/krane/blob/master/charts/krane/templates/deployment.yaml#L48 and https://github.com/appvia/krane/blob/master/charts/krane/templates/deployment.yaml#L62.

I've created PR for that fix #278

@nekwar nekwar added the bug Something isn't working label Nov 23, 2022
@marcinc
Copy link
Contributor

marcinc commented Nov 30, 2022

Hi @nekwar. Thanks for the issue report. I left a couple of small comments on the related PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants