Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failOnLineEndingDifferences not working #122

Open
bzuillsmith opened this issue Sep 13, 2021 · 3 comments
Open

failOnLineEndingDifferences not working #122

bzuillsmith opened this issue Sep 13, 2021 · 3 comments

Comments

@bzuillsmith
Copy link
Contributor

bzuillsmith commented Sep 13, 2021

I'm on v3.0.5 and approvals keeps failing for line ending differences. I've done a byte by byte comparison and confirmed it's just a difference of line endings. The reporter does not affect this, does it? I'm using vscode as the reporter.

I'm using verifyAsJson

@staxmanade
Copy link
Member

@bzuillsmith Could you give https://github.com/approvals/Approvals.NodeJS/releases/tag/v4.0.0-beta.1 a shot? I was able to fix a couple issues around that.

@bzuillsmith
Copy link
Contributor Author

It appears a commit has already been made to fix this, but it's not in the latest beta.

Without this change in FileApprover, it fails on windows when there are line break differences because the buffers are not the same length

@bzuillsmith
Copy link
Contributor Author

I know you are busy and haven't had time to maintain this much (I feel you, been struggling to find time for this OS lib of mine that I want to use Approvals in), but I can't really use the library until this is published. Any chance of a quick publish of the latest changes in the near future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants