Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct lighting still visible in reflections even when it's disabled #2861

Open
usakhelo opened this issue May 5, 2020 · 2 comments
Open

Comments

@usakhelo
Copy link
Contributor

usakhelo commented May 5, 2020

Hi,
This issue is visible when non-physical lights are used.
There are spot lights in this scene but direct lighting is disabled. Nonetheless shadows and lighting is visible in reflection:
image

I think it comes from this line in on_scatter function in ptlightingengine.cpp

if (m_params.m_enable_dl || vertex.m_path_length > 1)
{
@oktomus
Copy link
Member

oktomus commented May 8, 2020

Visible in reflection and direct lighting are two different things right ?

@Mango-3
Copy link
Member

Mango-3 commented May 9, 2020

Yes, I think the definition of direct lighting is lighting provided from a source without reflection from other surfaces.

If you set the object visibility flags for shadow, specular and glossy to off for the yellow pot you should have no reflected image visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants