Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type (RBS) #296

Open
KazuCocoa opened this issue Dec 26, 2020 · 6 comments
Open

add type (RBS) #296

KazuCocoa opened this issue Dec 26, 2020 · 6 comments

Comments

@KazuCocoa
Copy link
Member

Not immediate, but it would be nice to have type.

e.g.

typeprof lib/appium_lib_core/driver.rb -o lib/appium_lib_core/driver.rbs
@KazuCocoa
Copy link
Member Author

https://github.com/appium/ruby_lib_core/compare/typeprof-trial?expand=1 is an example.
I tweaked untyped a bit.

Probably we'll get a library that generates RBS files from yard (docstring).

@aguspe
Copy link
Contributor

aguspe commented Jul 20, 2024

Hi @KazuCocoa I hope you are doing great, I made the RBS implementation for selenium SeleniumHQ/selenium#13234 and if you are looking for help, I can start working on this for appium tomorrow

have a grat day!

@KazuCocoa
Copy link
Member Author

Oh, thank you!
I haven't caught up with these RBS stuff so long so it should help me to understand that well. I don't have any concrete plans to modify this library so much (except for updating to follow selenium ruby bindings), thus I'm happy to see RBS stuff @aguspe

@aguspe
Copy link
Contributor

aguspe commented Jul 21, 2024

Awesome @KazuCocoa then I will get working on it! have a great weekend :)

@aguspe
Copy link
Contributor

aguspe commented Jul 22, 2024

Hi @KazuCocoa I hope you had a great weekend, I started adding this PR to slowly build RBS support because one of my mistakes on Selenium was making the PRs too big at the beginning, making it more difficult for reviewers to go through them, so I hope it helps :)

@KazuCocoa
Copy link
Member Author

thank you! I'll take a look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants