Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: add sessions in /status endpoint #19857

Open
KazuCocoa opened this issue Mar 4, 2024 · 3 comments
Open

[Feat]: add sessions in /status endpoint #19857

KazuCocoa opened this issue Mar 4, 2024 · 3 comments
Labels

Comments

@KazuCocoa
Copy link
Member

KazuCocoa commented Mar 4, 2024

{
  "ready": true or false
  "message": "current string",
  "sessions": {the same body with /sessions}
}

The sessions format would be the same as /sessions endpoint.

[
  {"id": "session id", "capabilities": {capabilities}}.
  {"id": "session id2", "capabilities": {capabilities2}}
]

since /sessions is deprecated as W3C capability

(Or the sessions key would be active_sessions?)

References:
#19851
#19856

@mykola-mokhnach
Copy link
Collaborator

I think this might be a serious security issue. Also it us usually not a good idea to add too much stuff into the /status API as it gets called frequently to verify server liveness by multiple clients

@mykola-mokhnach
Copy link
Collaborator

#19856 seems like a better idea for me because:

  • it is secure, only people that need sessions info to be exposed are going to enable the plugin
  • we don't put unnecessary payload/add performance hit on the /status API

@eglitise
Copy link
Collaborator

eglitise commented Mar 4, 2024

Hmm.... I am inclined to agree on both points here. Current /sessions can indeed be treated a security issue, and if /status does get called often, it is definitely beneficial to keep its response compact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants