Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser build doesn't work in Safari #103

Open
jlipps opened this issue Aug 25, 2021 · 3 comments
Open

browser build doesn't work in Safari #103

jlipps opened this issue Aug 25, 2021 · 3 comments
Labels
bug Something isn't working dependencies Dependency updates, removals or additions

Comments

@jlipps
Copy link
Member

jlipps commented Aug 25, 2021

Some bundled dependency has an invalid regex according to Safari.

@jlipps
Copy link
Member Author

jlipps commented Aug 25, 2021

Results of my investigation:

  • the dependency which appears to be the problem is normalize-url.
  • normalize-url appears to have received a fix which is published in 7.0.1
  • normalize-url appears in our dep tree in many places, but the most likely dep path for the error to have occurred is: web2driver > webdriver > got > cacheable-request > normalize-url.
  • I tried to submit a PR to cacheable-request with an updated version of normalize-url, but it appears that v7.0.0 of normalize-url was a big breaking change, making the module ESM only. to support it from cacheable-request looks to be a sizable change. I created an issue at the cacheable-request repo to seek further guidance.
  • Even if the cacheable-request step is fixed, it looks like we'd need to trigger updates in got, webdriver, and web2driver. Hoping that would be easier, though I'm not sure how well ESM plays with the build systems for web2driver and the inspector.

As of now, it looks as if there's no path forward to fixing this particular issue.

@eglitise
Copy link
Collaborator

  • normalize-url 7.0.3 is included in cacheable-request 8.0.1
  • cacheable-request v8 (actually v10) is included in got 12.5.0
  • got 12.5.0 (actually 12.6.1) is included in webdriver 8.10.6

Seems like all that's left is to bump web2driver to this webdriver version or newer. It needs to be webdriver v8, because webdriver v7 is currently still on got 11.

@eglitise eglitise added bug Something isn't working dependencies Dependency updates, removals or additions labels Jul 12, 2023
@jlipps
Copy link
Member Author

jlipps commented Jul 12, 2023

OK, I'll make a task to update web2driver to latest webdriver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Dependency updates, removals or additions
Projects
None yet
Development

No branches or pull requests

2 participants