Skip to content
This repository has been archived by the owner on Dec 20, 2022. It is now read-only.

Eclipse formatting rules should be provided for consistent source code formatting #27

Open
pfistererm opened this issue Jul 10, 2019 · 2 comments
Labels
Prio: Medium Medium Priority Status: Accepted Issue or PR is accepted Type: Maintenance Issue or PR is a maintenance work

Comments

@pfistererm
Copy link
Contributor

Eclipse formatting rules should be provided for consistent source code formatting

Feature request

Expected Behavior - What where you expecting to happen?

There should be a file formatting_rules.xml (or similar) that can be imported into Eclipse.
It should contain formatting rules that are mandatory for the project.

Current Behavior - What happens?

Since default formatting in Eclipse is different from the current source formatting, if a reformatting of source code is done in Eclipse the resulting formatting is different. That leads to confusing diffs that hide the real changes.

Possible Solution

Provide a settings file with mandatory formatting rules.

Context

Notes and further information

@pfistererm pfistererm added Type: Feature Issue or PR is a new feature Status: Pending Issue or PR awaits response Prio: Triage Triage Priority labels Jul 10, 2019
@d-gs
Copy link
Member

d-gs commented Jul 12, 2019

Should we use the Google Style Guide (https://google.github.io/styleguide/javaguide.html) on this project? They provide the eclipse formatting rule (and also for other IDEs), which can be imported easily (https://github.com/google/styleguide/blob/gh-pages/eclipse-java-google-style.xml).

Also, we should consider some maven plugin to check the styleguide on Travis.

@StefanFranzWeiser
Copy link
Member

We should force the usage of a standardized formater. We need to have a look on impacts and changes to the default (Eclipse) formatting.

@holzerma holzerma added Prio: Medium Medium Priority Status: Accepted Issue or PR is accepted Type: Maintenance Issue or PR is a maintenance work and removed Prio: Triage Triage Priority Status: Pending Issue or PR awaits response Type: Feature Issue or PR is a new feature labels Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Prio: Medium Medium Priority Status: Accepted Issue or PR is accepted Type: Maintenance Issue or PR is a maintenance work
Development

No branches or pull requests

4 participants