You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 28, 2024. It is now read-only.
I may misunderstood the intention of this function, however it appears to me that line 129 should replace the occurrence of key with fullPath, otherwise, if that function was given an input like so:
fieldPathsAsString({ a: { a: { a: '' } } })
The result would be: ['a', 'a', 'a.a.a']
Whereas I believe the expectation is for that input to return: ['a', 'a.a', 'a.a.a']?
Please let me know if my assumption is correct and I can open a PR, cheers
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In https://github.com/apollosolutions/federation-subscription-tools/blob/main/src/datasources/GatewayDataSource/index.js you have a function
fieldPathsAsStrings
.I may misunderstood the intention of this function, however it appears to me that line 129 should replace the occurrence of
key
withfullPath
, otherwise, if that function was given an input like so:fieldPathsAsString(
{ a: { a: { a: '' } } }
)The result would be:
['a', 'a', 'a.a.a']
Whereas I believe the expectation is for that input to return:
['a', 'a.a', 'a.a.a']
?Please let me know if my assumption is correct and I can open a PR, cheers
The text was updated successfully, but these errors were encountered: