Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

fieldPathsAsStrings potential issue? #9

Open
sean-clarke opened this issue Aug 3, 2021 · 0 comments
Open

fieldPathsAsStrings potential issue? #9

sean-clarke opened this issue Aug 3, 2021 · 0 comments

Comments

@sean-clarke
Copy link

In https://github.com/apollosolutions/federation-subscription-tools/blob/main/src/datasources/GatewayDataSource/index.js you have a function fieldPathsAsStrings.

I may misunderstood the intention of this function, however it appears to me that line 129 should replace the occurrence of key with fullPath, otherwise, if that function was given an input like so:
fieldPathsAsString({ a: { a: { a: '' } } })
The result would be:
['a', 'a', 'a.a.a']
Whereas I believe the expectation is for that input to return:
['a', 'a.a', 'a.a.a']?

Please let me know if my assumption is correct and I can open a PR, cheers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant