-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High increase of base memory usage by Router v1.46.0 #5163
Labels
Comments
Thanks for raising this issue. We also spotted that increase of base memory consumption and we already fixed it on |
Merged
The v1.47.0 not only fixed this issue but also decreased our steady memory usage by around 10% which is awesome! So, great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The latest Router version v1.46.0 appears to be requiring high memory compared to previous versions.
To Reproduce
Steps to reproduce the behavior:
Version 1.46.0 - High Memory Usage
Brach with reproduction: https://github.com/juancarlosjr97/apollo-graphql-federation-memory-leak/tree/router-1.46.0
Note: This has been noticed in a Router running with enterprise features enabled, but the reproduction is using the router configuration without enterprise features enabled
docker compose up
docker stats
In the enterprise features enabled, the Router containers are between 210 and 200 MiB and on start up goes up to 260 MiB and then goes down and stable between 210 and 200 MiB.
Version v1.45.1 - Lower memory usage
docker compose up
docker stats
There is a minor increase also between version 1.44.0 and 1.45.1 from 32% to 40% utilization without any change in consumer traffic.
In the enterprise features enabled, the Router containers are between 90 and 110 MiB.
Expected behavior
Unclear if version 1.46.0 requires a high memory base from the release notes https://github.com/apollographql/router/releases/tag/v1.46.0 but the 1.46.0...1.45.1 enables
serde
in the parking_lot dependencydependency the https://github.com/apollographql/router/blame/63e9fa287ba40c3dd94ea75dd5fdfe1795a75fd5/apollo-router/Cargo.toml#L246
Details of testing
The text was updated successfully, but these errors were encountered: