Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many lexer errors do not have a location #731

Closed
goto-bus-stop opened this issue Nov 9, 2023 · 1 comment · Fixed by #886
Closed

Many lexer errors do not have a location #731

goto-bus-stop opened this issue Nov 9, 2023 · 1 comment · Fixed by #886
Labels
bug Something isn't working

Comments

@goto-bus-stop
Copy link
Member

Description

Many errors emitted by the lexer do not set the error.index property, so they point to the start of the document by default.

Steps to reproduce

Input a GraphQL document with unexpected characters:

type Query {
  // Some invalid characters
  user: User
}

Expected result

Syntax errors point to the correct position

Actual result

rror: syntax error: Unexpected character "/"
   ╭─[q.graphql:1:1]
   │
 1 │ type Query {
   │ ┬
   │ ╰── Unexpected character "/"
───╯
Error: syntax error: Unexpected character "/"
   ╭─[q.graphql:1:1]
   │
 1 │ type Query {
   │ ┬
   │ ╰── Unexpected character "/"
───╯
@goto-bus-stop goto-bus-stop added bug Something isn't working triage labels Nov 9, 2023
@SimonSapin
Copy link
Contributor

I’d be in favor of eventually removing the Error::new constructor that sets the index to zero, making the index always provided by the caller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants