Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gobble up n-ronn fixes for 0.10.1 #87

Closed
7 tasks done
Tracked by #103
apjanke opened this issue Dec 31, 2022 · 10 comments
Closed
7 tasks done
Tracked by #103

Gobble up n-ronn fixes for 0.10.1 #87

apjanke opened this issue Dec 31, 2022 · 10 comments
Assignees
Labels
enhancement New feature or request infrastructure
Projects
Milestone

Comments

@apjanke
Copy link
Owner

apjanke commented Dec 31, 2022

Per this discussion in #82, the RubyGems folks started work on another "nronn" fork and made some enhancements, mostly for maintainability. To keep the tribes united and avoid the need for another fork, pull in their enhancements and see if Ronn-NG can serve that purpose itself.

Roll these out in a 0.10.1 release soon, since it looks like a bunch of Ronn-NG users have been using the prerelease for the last year or so!

References

TODO

TODO later in other tickets:

Most of these mean pulling in tnir's work from commits in n-ronn. Looks like the commits can't be applied directly because our repos have diverged a bit, mostly from them switching to GH Workflows. I'm new to GH Workflows, so if I adopt that, I'll want to work through it myself instead of just pulling tnir's commits.

@apjanke apjanke added enhancement New feature or request infrastructure labels Dec 31, 2022
@apjanke apjanke self-assigned this Dec 31, 2022
@apjanke apjanke added this to Needs triage in ronn-ng via automation Dec 31, 2022
@apjanke apjanke moved this from Needs triage to High priority in ronn-ng Dec 31, 2022
@apjanke apjanke added this to the 0.10.1 milestone Dec 31, 2022
@apjanke apjanke mentioned this issue Dec 31, 2022
4 tasks
@deivid-rodriguez
Copy link
Contributor

deivid-rodriguez commented Jan 1, 2023

@apjanke Even if you can't cherry-pick commits directly, you can still manually add a Co-authored-by: line to the commit message to give proper attribution to the author of the changes. See https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors.

@apjanke apjanke mentioned this issue Jan 6, 2023
@apjanke
Copy link
Owner Author

apjanke commented Jan 6, 2023

I think I've pulled in all the major nronn fixes & enhancements now (except for enabling GitHub Pages as a doco site, which I'll do later), and I did a big Git commit history rewrite to tidy things up, and add "Co-authored-by:" attribution for @tnir on the relevant commits. It's merged to main now.

A 0.10.1pre2 prerelease will be coming out soon.

@apjanke apjanke closed this as completed Jan 6, 2023
ronn-ng automation moved this from High priority to Closed Jan 6, 2023
@apjanke apjanke changed the title Gobble up nronn enhancements Gobble up n-ronn fixes Jan 6, 2023
@apjanke apjanke changed the title Gobble up n-ronn fixes Gobble up n-ronn fixes for 0.10.1 Jan 6, 2023
@apjanke apjanke reopened this Jan 6, 2023
ronn-ng automation moved this from Closed to Needs triage Jan 6, 2023
@apjanke
Copy link
Owner Author

apjanke commented Jan 6, 2023

Reopened this issue to include doing the 0.10.1 release itself, since that's going to need some further work, and I don't want to create a separate ticket for it and split the conversation/record.

There's some fiddly stuff with regenerating the ronn man pages, plus the gem publishing process, which will need at least one more prerelease for review, and I have to fix the broken Ruby/gems environment on my local Mac and make sure the Ronn-NG bundled stuff works with a "proper" Ruby 3.x environment.

@apjanke
Copy link
Owner Author

apjanke commented Jan 17, 2023

I think I've got my Ruby environment and RubyGems release act together a bit more now. Mostly boils down to "you need to set $GEM_HOME if you're running on a box with a locked-down system Ruby/Gems installation", I think.

I have published a new 0.10.1.pre2 preview to RubyGems, from the branch WIP/https-ify. If that works out, I'll merge it and send it out as the real 0.10.1 Ronn-NG release.

@apjanke
Copy link
Owner Author

apjanke commented Jan 23, 2023

Okay, still looking good. I've merged the pending changes to master, made a new 0.10.1.pre3 release, and published it to RubyGems. If no complaints in a couple days, I'll make an actual 0.10.1 release.

@thesamesam
Copy link

Did any problems come up in the end? Thank you for working on this!

@apjanke
Copy link
Owner Author

apjanke commented Mar 18, 2023

Uh, yeah: I'm working for a startup at my day job, and things got busy, and then our bank collapsed, and stuff.

But in terms of this code for ronn-ng, no issues, and I'll try to get a release rolled out this weekend! Sorry for the delay here.

@thesamesam
Copy link

Oh bloody hell, I'm sorry! Please don't worry about this, I just came across it and got curious.

But many thanks, whenever it happens, be it this weekend or many months away. I hope things are getting a bit better for you now!

@apjanke
Copy link
Owner Author

apjanke commented Mar 19, 2023

No worries! My work survived the SVB blowup just fine, and I do this ronn-ng stuff for fun. It's not a burden, and I appreciate getting engagement from users like this. :)

@apjanke
Copy link
Owner Author

apjanke commented Jan 3, 2024

Marking this as closed again. The fixes are pulled in and the tests are passing again now that #102 is (I think) fixed, so an 0.10.1 release will be coming out soon.

@apjanke apjanke closed this as completed Jan 3, 2024
ronn-ng automation moved this from Needs triage to Closed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure
Projects
Status: Closed
ronn-ng
  
Closed
Development

No branches or pull requests

3 participants