-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applying a Spec resource from standard input doesn't upload the spec #1227
Comments
I agree, it seems intuitive that the content should be included, however the issue with this is that as the input is simply a byte stream which could be coming from anywhere - including even a non-file based resource, there is no base path to use to derive the referenced |
That makes sense. In that case, I would expect some kind of error response because it's guaranteed never to work but fails quite silently. Perhaps the Spec resource shouldn't be supported via stdin. It would be possible if you could inline the spec in the resource, but I recall a previous issue (can't find it right now) where it was decided not to support this. |
I agree, it absolutely shouldn't fail silently. There should be at least a warning, or perhaps an error with the ability to override. As for inlining, I'm not sure where that was decided against, either. It was mentioned as an option with potential drawbacks in this earlier superceded issue (#228), but I don't see any discussion or decision on that or later against it. It doesn't seem untenable. |
Given the following Spec resource in the file resource.yaml:
It's successfully published to the registry when running:
When applying the resource from standard input the specification is created with the filename in the resource; however, the specification content is not published.
GetApiSpecContents when using gRPC UI returns the following:
I would expect the specification content to be uploaded when applying from standard input.
The text was updated successfully, but these errors were encountered: