Add get_run_state method to BasicCrawler

[Pijukatel]

BasicCrawler has several internal state flags and also it's internal component _autoscaled_pool has specific states. Add public method that will analyze internal state flags and state of _autoscaled_pool and return public assessment of the crawler state.

Discussed here:
#921 (comment)
(Update the test discussed there using the newly added get_run_state method.)

[B4nan]

The name feels a bit too similar to crawler.useState(), which I can imagine we are also missing in python?

https://github.com/apify/crawlee/blob/02a598c2a501957f04ca3a2362bcee289ef861c0/packages/basic-crawler/src/internals/basic-crawler.ts#L989

[Pijukatel]

The name feels a bit too similar to crawler.useState(), which I can imagine we are also missing in python?

https://github.com/apify/crawlee/blob/02a598c2a501957f04ca3a2362bcee289ef861c0/packages/basic-crawler/src/internals/basic-crawler.ts#L989

I admit that crawler.useState and crawler.getState could make users think that it is related functionality. Sadly useState is somewhat strange name and I would be in favor of making the name more explicit to describe what it is actually doing, something along the line getGlobalState, or getSharedState or getSharedValues or getAutosavedAtate or useSharedValues ...

crawler.getState -> returning for example "Running" seems pretty obvious on the other hand. So I am not much in favor of choosing worse name to not collide with useState

Maybe crawler.getStatus or crawler.getCrawlingStatus would be explicit enough and not colliding with useState?

I see that in JS there is some code related to StatusMessage, but that actually seems to be somehow related to crawler internal state as well.

[B4nan]

Even if we rename it, this sounds like a bad idea to introduce something completely different with such a similar name. And I would personally not rename it. Its a very common thing to use, unlike this new method you are proposing here. I would rather pick a longer name for that one. getCrawlingStatus sounds fine'ish.

[janbuchar]

How does get_run_state sound?