Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new base & memory storage clients #783

Open
vdusek opened this issue Dec 5, 2024 · 1 comment
Open

Introduce new base & memory storage clients #783

vdusek opened this issue Dec 5, 2024 · 1 comment
Assignees
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@vdusek
Copy link
Collaborator

vdusek commented Dec 5, 2024

New interface of the BaseStorageClient

  • Propose & implement a new BaseStorageClient.
  • It should introduce a new interface, which does not have to be dependent on the ApifyStorageClient. Instead, we should implement an adapter for it.
  • The MemoryStorageClient should implement this interface.

The issues with the current MemoryStorageClient

@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Dec 5, 2024
@janbuchar
Copy link
Collaborator

Regarding that comment on #691, I think that just a Protocol with select properties should do it.

@vdusek vdusek added the debt Code quality improvement or decrease of technical debt. label Dec 16, 2024
@vdusek vdusek self-assigned this Jan 6, 2025
@vdusek vdusek changed the title Refactoring of memory storage client Introduce new base & memory storage clients Jan 6, 2025
@vdusek vdusek added this to the 105th sprint - Tooling team milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

2 participants