Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish up logging #157

Open
janbuchar opened this issue May 20, 2024 · 2 comments
Open

Polish up logging #157

janbuchar opened this issue May 20, 2024 · 2 comments
Labels
t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@janbuchar
Copy link
Collaborator

In the current state, we make a new logger in every module that needs to log something. There is CrawleeLogFormatter, which handles logging in the console.

  • our loggers should default to the "info" level
  • ??? the log format for Apify platform may be different (doesn't it ingest JSON? probably not, but I'm not sure)
  • in JS Crawlee, some classes accept loggers instead of creating them - we may want to revisit that
  • printing extra key-value information should now be possible via kwargs of logging.info and related methods - should we use that?
@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label May 20, 2024
@vdusek
Copy link
Collaborator

vdusek commented May 20, 2024

Also, a question that comes to mind: do we want to override the default Python logger formatting? considering Crawlee is a library

@janbuchar
Copy link
Collaborator Author

Also, a question that comes to mind: do we want to override the default Python logger formatting? considering Crawlee is a library

And also a framework... It is not unusual for frameworks to define their own loggers. But if a client wants to override that, we should make it easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

2 participants