Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support input schema defaults locally in Actor.getInput() #287

Open
B4nan opened this issue Feb 28, 2024 · 2 comments
Open

Support input schema defaults locally in Actor.getInput() #287

B4nan opened this issue Feb 28, 2024 · 2 comments
Assignees
Labels
product roadmap Issues synchronized to product roadmap. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@B4nan
Copy link
Member

B4nan commented Feb 28, 2024

Currently, the input schema is ignored locally, and to respect the defaults inside it, you need to use the Apify CLI to run the actor, which creates the INPUT.json file based on those defaults when missing.

Implement input schema support on the SDK level, so this works on the fly if the INPUT.json file is missing. If it's there, we should still fill in the missing fields that have defaults in the input schema.

The goal of this PR is to unify the local vs platform behavior. As a nice side effect, there shouldn't be any need to use the Apify CLI to run the actor, as npm start should behave the same with this implemented.

@B4nan B4nan added tech roadmap Issues contributing to tech roadmap. t-tooling Issues with this label are in the ownership of the tooling team. labels Feb 28, 2024
@mtrunkat
Copy link
Member

Defaults and prefil, no? In fact, I am not sure, let's discuss that on Slack.

@B4nan
Copy link
Member Author

B4nan commented Feb 29, 2024

The idea is to align behavior with the platform without the need for apify run, I am never sure about default vs prefill :]

@B4nan B4nan added product roadmap Issues synchronized to product roadmap. and removed tech roadmap Issues contributing to tech roadmap. labels Nov 29, 2024
@mtrunkat mtrunkat changed the title Support input schema defaults in Actor.getInput() Support input schema defaults locally in Actor.getInput() Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product roadmap Issues synchronized to product roadmap. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

3 participants