Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web scraping basics courses: Correct a screenshot, remove notes #1417

Open
honzajavorek opened this issue Jan 20, 2025 · 0 comments
Open

Web scraping basics courses: Correct a screenshot, remove notes #1417

honzajavorek opened this issue Jan 20, 2025 · 0 comments
Assignees
Labels
t-academy Issues related to Web Scraping and Apify academies.

Comments

@honzajavorek
Copy link
Collaborator

All JS examples in sources/academy/webscraping/scraping_basics_python/02_devtools_locating_elements.md have semicolons at the end of the line, except of one. It's an inconsistency and the reader might wonder why suddenly the semicolon isn't there. Currently there is a note which mitigates the problem:

:::note About the missing semicolon

In the screenshot, there is a missing semicolon `;` at the end of the line. In JavaScript, semicolons are optional, so it doesn't make a difference here.

:::

Better solution would be to create a new screenshot with the semicolon in place, so that there's nothing to think about, and then the note can be removed. The same is valid for a similar lesson in the JavaScript course of web scraping basics.

@honzajavorek honzajavorek added the t-academy Issues related to Web Scraping and Apify academies. label Jan 20, 2025
@honzajavorek honzajavorek self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-academy Issues related to Web Scraping and Apify academies.
Projects
None yet
Development

No branches or pull requests

1 participant