-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken links #115
Comments
The link to `PuppeteerPool` won't work as the page is no longer part of 1.0 sdk docs, found a note about it being deprecated and replaced with `BrowserPool`, but i'd rather let you handle that change as I don't fully understand all the differences. Related: #115
ooops, should have been a PR :] reposting the commit message here:
|
@B4nan Is this still relevant? |
Fixed the links for And apparently the docs (on web, not sdk docs) will need a rebuild, the Btw we might also make the old links just work (add redirects and keep the old url working too). I know how to do that in docusaurus v2, but there will be probably same/similar way to do so in v1 too. e.g. this is how I am handling old URLs that were directy on the domain ( https://github.com/mikro-orm/mikro-orm/blob/master/docs/static/custom-driver/index.html |
Redirects are not easy to do in v1. Will have to do it once we migrate to v2. I would point the invalid puppeteer pool link to https://github.com/apify/browser-pool for now. |
https://apify.com/apify/cheerio-scraper - link to https://sdk.apify.com/docs/api/autoscaledpool
https://apify.com/apify/puppeteer-scraper - links to https://sdk.apify.com/docs/api/autoscaledpool and https://sdk.apify.com/docs/api/puppeteerpool
The text was updated successfully, but these errors were encountered: