Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated message for Apideck\Client\Model\GetConnectionsResponse methods implementing ArrayAccess PHP interface #54

Open
rneuter opened this issue Jan 24, 2024 · 0 comments

Comments

@rneuter
Copy link

rneuter commented Jan 24, 2024

Hi,

The Apideck\Client\Model\GetConnectionsResponse methods implementing ArrayAccess PHP interface are not compatible with this interface, making PHP noticing us with a deprecated log:

Return type of Apideck\Client\Model\GetConnectionsResponse::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

🐞 Debugging informations

File: /var/www/html/vendor/apideck-libraries/php-sdk/src/gen/lib/Model/GetConnectionsResponse.php
Line: 319
Error level: 8192

As mentioned by PHP, arguments and return types are missing in these implementations:

actual_version

PHPStan hint:
actual_version_phpstan_hint

Fixed version:
fixed_version

⚠️ About the fixed version ⚠️
The fix I provided is not compatible with PHP ^7.3, which is a version supported by your PHP ApiDeck library (mixed pseudo type was added in PHP 8.0).

Also, PHP versions 7.3 to 8.0 are not supported anymore, maybe it will be time to bump this package version to a new major one introducing this breaking change? I let you think about the strategy 😄

Ping me if you need something else, I'll be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant