use error.h *only if it exists* #119
Conversation
|
This is effectively the same as just removing the #include. That may be the correct solution here, as error.h does seem to be unused. I wonder if errno.h was intended? |
| @@ -22,7 +22,9 @@ | |||
| * | |||
| */ | |||
|
|
|||
| #ifdev HAVE_ERROR_H | |||
There was a problem hiding this comment.
Is "#ifdev" a mistake (should be "#ifdef")? How did this successfully compile ?
There was a problem hiding this comment.
Of course !
Sorry, I'm not sure how it happened, i don't have it in my original "patch" :(
|
Can/will this be integrated ? |
|
In its current state I would not merge this for the reason I hinted at in my comment: adding that #ifdef with no other changes effectively just removes the #include. I'd like to see analysis to determine if this should be errno.h now or simply be removed, and if this has always been the case or if something changed at some point. |
fixes #117