-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use error.h *only if it exists* #119
base: master
Are you sure you want to change the base?
Conversation
This is effectively the same as just removing the #include. That may be the correct solution here, as error.h does seem to be unused. I wonder if errno.h was intended? |
@@ -22,7 +22,9 @@ | |||
* | |||
*/ | |||
|
|||
#ifdev HAVE_ERROR_H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "#ifdev" a mistake (should be "#ifdef")? How did this successfully compile ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course !
Sorry, I'm not sure how it happened, i don't have it in my original "patch" :(
Can/will this be integrated ? |
In its current state I would not merge this for the reason I hinted at in my comment: adding that #ifdef with no other changes effectively just removes the #include. I'd like to see analysis to determine if this should be errno.h now or simply be removed, and if this has always been the case or if something changed at some point. |
fixes #117