Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use error.h *only if it exists* #119

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

use error.h *only if it exists* #119

wants to merge 3 commits into from

Conversation

dgeo
Copy link

@dgeo dgeo commented Dec 10, 2016

fixes #117

@dhawes
Copy link
Contributor

dhawes commented Dec 13, 2016

This is effectively the same as just removing the #include.

That may be the correct solution here, as error.h does seem to be unused. I wonder if errno.h was intended?

@@ -22,7 +22,9 @@
*
*/

#ifdev HAVE_ERROR_H
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "#ifdev" a mistake (should be "#ifdef")? How did this successfully compile ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course !
Sorry, I'm not sure how it happened, i don't have it in my original "patch" :(

@dgeo
Copy link
Author

dgeo commented Apr 6, 2017

Can/will this be integrated ?

@dhawes
Copy link
Contributor

dhawes commented Apr 6, 2017

In its current state I would not merge this for the reason I hinted at in my comment: adding that #ifdef with no other changes effectively just removes the #include.

I'd like to see analysis to determine if this should be errno.h now or simply be removed, and if this has always been the case or if something changed at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of error.h in mod_auth_cas.c
3 participants