sql parser support clickHouse #31226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got it！ |
linghengqian
previously approved these changes
May 15, 2024
strongduanmu
requested changes
May 15, 2024
|
|
||
| unreservedWord | ||
| : AFTER | ALIAS | ALL | ALTER | AND | ANTI | ANY | ARRAY | AS | ASCENDING | ASOF | AST | ASYNC | ATTACH | BETWEEN | BOTH | BY | CASE | ||
| | CAST | CHECK | CLEAR | CLUSTER | CODEC | COLLATE | COLUMN | COMMENT | CONSTRAINT | CREATE | CROSS | CUBE | CURRENT | DATABASE |
There was a problem hiding this comment.
Please keep same indent with previous line.
| | TABLES | TEMPORARY | TEST | THEN | TIES | TIMEOUT | TIMESTAMP | TOTALS | TRAILING | TRIM | TRUNCATE | TO | TOP | TTL | TYPE | ||
| | UNBOUNDED | UNION | UPDATE | USE | USING | UUID | VALUES | VIEW | VOLUME | WATCH | WHEN | WHERE | WINDOW | WITH | ||
| ; | ||
| interval: SECOND | MINUTE | HOUR | DAY | WEEK | MONTH | QUARTER | YEAR; |
There was a problem hiding this comment.
Please add new line before interval.
| grammar BaseRule; | ||
|
|
||
| import LexerSymbol, LexerKeyword, LexerClickHouseKeyword, LexerLiterals; | ||
|
|
There was a problem hiding this comment.
Please only keep one line here.
|
|
||
| delete | ||
| : | ||
| // DELETE singleTableClause whereClause? |
There was a problem hiding this comment.
Please remove useless sytax.
| /** | ||
| * Statement visitor facade for ClickHouse. | ||
| */ | ||
| public class ClickHouseStatementVisitorFacade implements SQLStatementVisitorFacade { |
There was a problem hiding this comment.
Please add final for this class.
| /** | ||
| * ClickHouse DAL statement visitor. | ||
| */ | ||
| public class ClickHouseDALStatementVisitor extends ClickHouseStatementVisitor implements DALStatementVisitor { |
There was a problem hiding this comment.
Please add final for this class.
| /** | ||
| * ClickHouse DCL statement visitor. | ||
| */ | ||
| public class ClickHouseDCLStatementVisitor extends ClickHouseStatementVisitor implements DCLStatementVisitor { |
There was a problem hiding this comment.
Please add final for this class.
| /** | ||
| * ClickHouse DDL statement visitor. | ||
| */ | ||
| public class ClickHouseDDLStatementVisitor extends ClickHouseStatementVisitor implements DDLStatementVisitor { |
There was a problem hiding this comment.
Please add final for this class.
| /** | ||
| * ClickHouse RL statement visitor. | ||
| */ | ||
| public class ClickHouseRLStatementVisitor extends ClickHouseStatementVisitor implements RLStatementVisitor { |
There was a problem hiding this comment.
Please add final for this class.
| /** | ||
| * ClickHouse TCL statement visitor. | ||
| */ | ||
| public class ClickHouseTCLStatementVisitor extends ClickHouseStatementVisitor implements TCLStatementVisitor { |
There was a problem hiding this comment.
Please add final for this class.
There was a problem hiding this comment.
@strongduanmu All done.
update g4 file to keep format consistent;
strongduanmu
approved these changes
May 16, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31224.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.