-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
customRuntimeOptions in "Creates a new Pulsar Source in cluster mode" API call in source connector doesn't add nodeselectors & tolerations #394
Comments
Related to #382 |
In this issue , you suggested to configure things by passing values to broker's config map. which i did
based on this configuration , this will add nodeSelectors test:value to all the functions which will be deployed. Which is correct its the default nodeSelector. But I want different nodeSelector for different functions which I deploy. So I should pass
If I don't pass customRuntimeOptions while creating the function , it works fine and take the default node selector |
@kunjbosamiaFalkonry One possible approach would be to create your own customizer implementation. Currently there's not an easy way to get your custom classes into use. You need a custom overlay docker image with the jar file in /pulsar/lib . There's a feature request to add init container support that could copy the jar file to /pulsar/lib when the pod starts. That's #491 / #240 . This is an open source project and contributions are more than welcome to improve Apache Pulsar Helm chart. |
Describe the bug
The API call "Creates a new Pulsar Source in cluster mode" LINK Adding node selectors and toleration under customRuntimeOptions flag doesn't seem to add those selectors & toleration to the created pulsar functions source pods. For reference I'm using apache pulsar installed using helm on k8
To Reproduce
Steps to reproduce the behavior:
"nodeSelectorLabels": {
"customLabel": "value"
},
"tolerations": [
{
"key": "custom-key",
"value": "value",
"effect": "NoSchedule"
}
]) As mentioned here
2, the created source connector doesn't have the node selector / toleration
Expected behavior
The passed nodeselectors and tolerations from customRuntimeOptions should be inherited onto the pods that get created
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: