Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart: add CI tests for Eclipse Link #375

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

adutra
Copy link
Contributor

@adutra adutra commented Oct 15, 2024

Description

Add more CI automated tests for the Helm chart, this time leveraging EclipseLink with H2.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • More tests for existing features

How Has This Been Tested?

In CI.

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue

Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@snazy snazy enabled auto-merge (squash) October 17, 2024 09:19
@snazy snazy merged commit 5ae0f0f into apache:main Oct 17, 2024
5 checks passed
@adutra adutra deleted the helm-persistence branch October 17, 2024 09:28
@ebyhr
Copy link
Contributor

ebyhr commented Oct 17, 2024

@adutra @snazy Could you confirm a CI failure on main branch? https://github.com/apache/polaris/actions/runs/11382155365/job/31665072150

@adutra
Copy link
Contributor Author

adutra commented Oct 17, 2024

@ebyhr this should fix it: #381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants