Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify dropwizard application log #367

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

verify dropwizard application log #367

wants to merge 10 commits into from

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Oct 12, 2024 •
edited
Loading

Description

add test to verify that there are zero errors in the dropwizard application log

Type of change

  • test suite

How Has This Been Tested?

Github Actions CI

Checklist:

  • I have performed a self-review of my code

@sullis
Copy link
Contributor Author

sullis commented Oct 18, 2024

ready for review

flyrain
flyrain reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@flyrain flyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sullis for working on it. LGTM overall. Left minor comments and some questions. The only thing I'm not sure is whether we need to check the archived log. +1 if 2M is big enough for the log in the test.

polaris-service/src/test/java/org/apache/polaris/service/PolarisApplicationIntegrationTest.java Outdated Show resolved Hide resolved
polaris-service/src/test/java/org/apache/polaris/service/PolarisApplicationIntegrationTest.java Outdated Show resolved Hide resolved
polaris-service/src/test/java/org/apache/polaris/service/PolarisApplicationIntegrationTest.java Outdated Show resolved Hide resolved
polaris-service/src/test/java/org/apache/polaris/service/PolarisApplicationIntegrationTest.java Show resolved Hide resolved
@sullis sullis force-pushed the sean/dropwizard-logging branch from d177de2 to 1b0d9f5 Compare November 10, 2024 22:44
@sullis sullis requested a review from adutra as a code owner November 10, 2024 22:44
@sullis
Copy link
Contributor Author

sullis commented Nov 10, 2024

Ready for review.

collado-mike
collado-mike approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@collado-mike collado-mike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slick

@sullis
Copy link
Contributor Author

sullis commented Nov 24, 2024

waiting for GitHub Actions approval.

@eric-maynard eric-maynard enabled auto-merge (squash) November 25, 2024 18:36
auto-merge was automatically disabled November 27, 2024 04:53

Head branch was pushed to by a user without write access

@sullis
Copy link
Contributor Author

sullis commented Nov 29, 2024

GitHub workflows awaiting approval.

@sullis
Copy link
Contributor Author

sullis commented Dec 1, 2024

workflows awaiting approval

@eric-maynard eric-maynard enabled auto-merge (squash) December 5, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyrain flyrain flyrain left review comments

@collado-mike collado-mike collado-mike approved these changes

@adutra adutra adutra approved these changes

@jbonofre jbonofre Awaiting requested review from jbonofre jbonofre is a code owner

@ashvina ashvina Awaiting requested review from ashvina ashvina is a code owner

@RussellSpitzer RussellSpitzer Awaiting requested review from RussellSpitzer RussellSpitzer is a code owner

@snazy snazy Awaiting requested review from snazy snazy is a code owner

@vvcephei vvcephei Awaiting requested review from vvcephei vvcephei is a code owner

@takidau takidau Awaiting requested review from takidau takidau is a code owner

@jackye1995 jackye1995 Awaiting requested review from jackye1995 jackye1995 is a code owner

@eric-maynard eric-maynard Awaiting requested review from eric-maynard eric-maynard is a code owner

@ebyhr ebyhr Awaiting requested review from ebyhr ebyhr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sullis @adutra @flyrain @collado-mike @eric-maynard