Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add basic Helm testing #352

Merged
merged 5 commits into from
Oct 15, 2024
Merged

CI: add basic Helm testing #352

merged 5 commits into from
Oct 15, 2024

Conversation

adutra
Copy link
Contributor

@adutra adutra commented Oct 7, 2024

Description

This PR introduces some basic CI testing for the Polaris Helm chart.

Type of change

CI Tests.

How Has This Been Tested?

CI.

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings

@@ -29,3 +29,6 @@ sources:
keywords:
- polaris
- iceberg
maintainers:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is the result of git shortlog -n -s -- helm. It must contain valid GitHub handles.

Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM - but add it as a required check?

.github/workflows/helm.yml Show resolved Hide resolved
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@snazy snazy enabled auto-merge (squash) October 15, 2024 13:06
@snazy snazy merged commit 0b1f606 into apache:main Oct 15, 2024
5 checks passed
snazy added a commit to snazy/polaris that referenced this pull request Oct 15, 2024
@flyrain
Copy link
Contributor

flyrain commented Oct 15, 2024

Looks like all OSS PRs are blocked by the helm tests reporting as the following screenshot shows. Any ideas?

image

@adutra adutra deleted the helm-ci branch October 15, 2024 17:08
@adutra
Copy link
Contributor Author

adutra commented Oct 15, 2024

@flyrain yes, that's unfortunate, but @snazy already put up a PR to fix it: #374 – please help us get that one merged 🙏

@flyrain
Copy link
Contributor

flyrain commented Oct 15, 2024

Cannot merge it from github due to the same blocker. We need a way to force push it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants