-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix calls to Exception.StackTrace #932
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
new Exception().StackTrace
is an incorrect translation from Java. We should find all calls toException.StackTrace
as well as theStackTrace
class and convert them correctly. From ChatGPT:We have a class called
StackTraceHelper
that we could add the support to convert it to a string. There are also several calls to.printStackTace()
that should be reviewed. In .NET,Exception.StackTrace
doesn't contain the exception type, so a lot of the tests useException.ToString()
instead. But we would be better off with a centralized way of dealing with stack traces (in Support) -StackTraceHelper
only applies to the test code, but there is code in production that is also not correctly translated. Of course, since it is something we own, moving it to Support is an option.In short, we want to review all of the code that was using
.getStackTrace()
or.printStackTrace()
in Lucene.Originally posted by @NightOwl888 in #926 (comment)
The text was updated successfully, but these errors were encountered: