Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support create partition table for non REST catalog #578

Open
FANNG1 opened this issue Aug 23, 2024 · 1 comment · May be fixed by #577
Open

support create partition table for non REST catalog #578

FANNG1 opened this issue Aug 23, 2024 · 1 comment · May be fixed by #577

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented Aug 23, 2024

The type of partition_spec in TableCreation is UnboundPartitionSpec, it's more dedicated to REST catalog, for non REST catalog seems more general to use PartitionSpec type. like

    let p = PartitionSpecBuilder::new(&table_schema)
        .add_partition_field("a", "bucket_a", Transform::Bucket(16))
        .add_partition_field("b", "b", Transform::Identity)
        .build()
        
    TableCreation::builder()
         .name(table_id.name.clone())
         .schema(table_schema.clone())
         .partition_spec(p).build()
@FANNG1 FANNG1 linked a pull request Aug 23, 2024 that will close this issue
Open
@liurenjie1024
Copy link
Contributor

Thanks @FANNG1 for contribution. I've left comments in your pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support create partition table for non REST catalog FANNG1/iceberg-rust
2 participants
@liurenjie1024 @FANNG1