Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid explicit cast during execution in corr aggregate function #13721

Open
2010YOUY01 opened this issue Dec 10, 2024 · 1 comment
Open

Avoid explicit cast during execution in corr aggregate function #13721

2010YOUY01 opened this issue Dec 10, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@2010YOUY01
Copy link
Contributor

Is your feature request related to a problem or challenge?

Thanks @jayzhan211 for noticing it in #13581 (comment)

Casting of input should be done automatically according to function signature
For example, the execution logic of corr is implemented in float64 type, so when input is int32 or other compatible type, it will automatically convert to Float64

If the casting logic is implemented correctly during planning, we can safely remove the explicit cast, however, if I try to remove it now, the benchmark query mentioned in #13581 won't run

Describe the solution you'd like

  1. Remove cast and fix the error
  2. Add the regression test

Describe alternatives you've considered

No response

Additional context

No response

@findepi
Copy link
Member

findepi commented Dec 11, 2024

Thanks for creating this issue

If the casting logic is implemented correctly during planning, we can safely remove the explicit cast, however, if I try to remove it now, the benchmark query mentioned in #13581 won't run

That sounds like a bug, right?

@findepi findepi added the bug Something isn't working label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants