Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[substrait] make dependency on parquet optional #13593

Closed
notfilippo opened this issue Nov 28, 2024 · 1 comment · Fixed by #13594
Closed

[substrait] make dependency on parquet optional #13593

notfilippo opened this issue Nov 28, 2024 · 1 comment · Fixed by #13594
Assignees
@notfilippo
Labels
enhancement New feature or request

Comments

@notfilippo
Copy link
Contributor

Is your feature request related to a problem or challenge?

The datafusion-substrait package currently depends on the datafusion crate with all default features enabled. This can force users that might want to use the substrait package to always have at least all the datafusion default features turned on.

Describe the solution you'd like

I propose that we hide parts of the datafusion-substrait crate that depend on datafusion's default feature behind some feature flags (enabled by default but that can be disabled by users)

Describe alternatives you've considered

No response

Additional context

No response
@notfilippo notfilippo added the enhancement New feature or request label Nov 28, 2024
@notfilippo
Copy link
Contributor Author

take

@notfilippo notfilippo mentioned this issue Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notfilippo notfilippo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(substrait): remove dependency on datafusion default features notfilippo/datafusion
1 participant
@notfilippo