-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Update bundled Abseil and gRPC #45063
Comments
I have a PR I dropped to do this, the target tree changed which makes this annoying IIRC #37066 |
Hm I guess I never pushed the changes, as the PR is just the changed versions.txt, I remember trying to move over absl to fetch content but that also meant moving over the dependencies/dependents and grew out of hand quickly |
Do you recall why did you drop the issue? I can't see logs for what was going on that PR. I am trying to figure out the current failure which seems to be a common one as per #45064 (comment) , basically solving:
|
Because of external project we have to replicate the abseil target tree, there is a bash oneliner commented in thirdparty cmake that explains it. And I think there were changes there that require it to be regenerated but it has been a long time. |
Describe the enhancement requested
We are currently using an Abseil version from 2021:
arrow/cpp/thirdparty/versions.txt
Lines 26 to 27 in 5a042fc
And a gRPC from 2022 (https://github.com/grpc/grpc/releases/tag/v1.46.2):
arrow/cpp/thirdparty/versions.txt
Lines 77 to 78 in 5a042fc
We should update those dependencies.
Component(s)
C++
The text was updated successfully, but these errors were encountered: