Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Issue: RegEx is not accepted in defineConfig.[name].input.filters.tags #1364

Closed
vitalikda opened this issue May 11, 2024 · 1 comment · Fixed by #1369
Closed

Type Issue: RegEx is not accepted in defineConfig.[name].input.filters.tags #1364

vitalikda opened this issue May 11, 2024 · 1 comment · Fixed by #1369
Labels
bug Something isn't working
Milestone

Comments

@vitalikda
Copy link

vitalikda commented May 11, 2024

I might be wrong here, due to Docs does not cover this. But looks like filters.tags excepts RegEx
Have been added here: #835

What are the steps to reproduce this issue?

  1. Add RegEx in defienConfig.[name].input.filters.tags

What happens?

Typescript shows error that only string[] is allowed
Regex filter works

What were you expecting to happen?

No type error

Any logs, error output, etc?

Looks like defienConfig uses InputOptions: https://github.com/anymaniax/orval/blob/master/packages/core/src/types.ts#L200
But type was updated only in NormalizedInputOptions: https://github.com/anymaniax/orval/blob/master/packages/core/src/types.ts#L156

What versions are you using?

Package Version: [email protected]

@melloware melloware added the bug Something isn't working label May 11, 2024
@melloware melloware added this to the 6.29.0 milestone May 14, 2024
@melloware
Copy link
Collaborator

Thanks to @AffeJonsson fixed for 6.29.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants