Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If "enable-status" is false, the connection to the backend server will fail #64

Open
viasnake opened this issue May 17, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@viasnake
Copy link

viasnake commented May 17, 2021

Describe the bug
When enable-status in server.properties is false, Failed to connect is displayed.

To Reproduce

  1. Set up Velocity & Catalyst.
  2. Set enable-status in server.properties to false.
  3. Failed to connect.

Expected behavior
The player will be successfully connected to the backend server.

Screenshots
image

Desktop (please complete the following information):

  • Velocity Version: 1.1.5
  • Catalyst Version: 0.3.2
  • Additional Plugins installed on velocity: Anvil 0.3.0

Additional context
This issue does not occur with Velocity alone, so you may want to mark it as a bug. If this is not fixed, it might be a good idea to provide a FAQ.

This issue is a bit tricky for the following reasons:

  • No errors will be output to the console at all.
  • Console of the backend server will log as if the player connected for a moment and then immediately disconnected.

Almost certainly, the following checks are causing this issue.
https://github.com/AnvilPowered/Catalyst/blob/088793a6de30fe200169ef365a1a8a319c127492/catalyst-velocity/src/main/java/org/anvilpowered/catalyst/velocity/listener/VelocityListener.java#L119-L120

However, simply removing this check does not seem like a good idea. I don't understand Java and Velocity, so I can't come up with a good solution.

@viasnake viasnake added the bug Something isn't working label May 17, 2021
@viasnake
Copy link
Author

I don't know why this happens, but redoing everything will fix it. I can tell you for sure that this is not caused by Proxy_Protocol.
If I can identify the cause I will open the issue again.

@viasnake
Copy link
Author

I found the cause.
When "enable-status" in "server.properties" is false, "Failed to connect" is displayed.
Usually "enable-status" is true by default, but I changed it to false for some reason. In any case, if you get the "Failed to connect" message as well, it is worth checking this setting.

Also, this issue does not occur with Velocity alone, so you may want to mark it as a bug. If this is not fixed, it might be a good idea to provide a FAQ.

@viasnake viasnake changed the title If ProxyProtocol is enabled, player cannot connect to server If "enable-status" is false, the connection to the backend server will fail May 29, 2021
@viasnake viasnake reopened this May 29, 2021
@viasnake
Copy link
Author

For now, I will reopen this issue, but feel free to close it if it not fixed.
A solution does exist for this issue. It's just hard to notice that it exists, and it doesn't affect most servers.

Sorry if this is a series of bad English. I'm not a native English speaker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant