-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] feat/refactor/docs: multiple providers, large refactor, configurable ticking interval, fix for jwks endpoint has different host #99
Open
antonengelhardt
wants to merge
36
commits into
main
Choose a base branch
from
mulitple-open-id-providers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonengelhardt
added
semver:minor
Release in the next minor version
feature
New Feature or enhancement
refactor
Code refactoring
docs
Documentation
labels
Sep 5, 2024
antonengelhardt
force-pushed
the
mulitple-open-id-providers
branch
2 times, most recently
from
September 5, 2024 22:02
e6806c9
to
0d882e9
Compare
This was referenced Sep 6, 2024
antonengelhardt
changed the title
[BREAKING] feat/refactor/docs: multiple providers, large refactor
[BREAKING] feat/refactor/docs: multiple providers, large refactor, configurable ticking interval, fix for jwks endpoint has different host
Sep 9, 2024
antonengelhardt
force-pushed
the
mulitple-open-id-providers
branch
2 times, most recently
from
September 9, 2024 16:00
80e497e
to
d94b6df
Compare
This was
linked to
issues
Sep 10, 2024
antonengelhardt
force-pushed
the
mulitple-open-id-providers
branch
from
October 2, 2024 08:41
36c5896
to
818a32c
Compare
antonengelhardt
force-pushed
the
mulitple-open-id-providers
branch
3 times, most recently
from
October 17, 2024 15:37
eb3e9de
to
17ac0f4
Compare
This was referenced Nov 4, 2024
Closed
* plugin can now have more than one oidc provider * the discovery will load information from all providers * user selects the provider on an auth page if there is >1 provider * more logs * more comments TODO: * error handling * performance and linting * large refactoring to file structure This is just a POC! THIS IS A BREAKING CHANGE! Signed-off-by: Anton Engelhardt <[email protected]>
* add auth.rs for code flow * rename cookies.rs to session.rs * add pause.rs Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
Signed-off-by: Anton Engelhardt <[email protected]>
this avoids problems with leftover cookie parts preventing decryption
Signed-off-by: Anton Engelhardt <[email protected]>
antonengelhardt
force-pushed
the
mulitple-open-id-providers
branch
from
November 4, 2024 17:28
55da665
to
9c4c076
Compare
Signed-off-by: Anton Engelhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
Documentation
feature
New Feature or enhancement
refactor
Code refactoring
semver:minor
Release in the next minor version
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes and why you made them
Multiple OpenID providers
_wasm-oidc-plugin/provider-selection?authorize_with_provider=wwu&return_to=lw
), which then redirect to theauthorization_endpoint
, because otherwise we would not be able to know which server sent the code in the code callback.Small features
ticking_interval_in_ms
)Refactor & fixes
jwks_uri
exposed at a different host than the openid-configuration host:scheme
to parseurl
as in fix(exclude): get scheme to parse url, more debug logs and yaml fmt #98Does this PR introduce a breaking change?
Warning
This PR introduces a breaking change:
Please see
envoy.yaml
for the updated config structureTODOs
Other information and Screenshots (if appropriate)
🤫 It has darkmode
Linked
For #93
more to come