C++ warning + fix

[JoD]

Using g++ (Ubuntu 13.2.0-23ubuntu4) 13.2.0 gives

antlr4/tree/ParseTree.h:50:18: warning: ‘virtual bool antlr4::tree::ParseTree::operator==(const antlr4::tree::ParseTree&) const’ was hidden [-Woverloaded-virtual=]
   50 |     virtual bool operator == (const ParseTree &other) const;
      |                  ^~~~~~~~
antlr4/RuleContext.h:135:10: note:   by ‘bool antlr4::RuleContext::operator==(const antlr4::RuleContext&)’
  135 |     bool operator == (const RuleContext &other) { return this == &other; } // Simple address comparison.

The operator== in RuleContext seems redundant, as the virtual one in ParseTree performs the same check?

Proposed fix: remove this line:

antlr4/runtime/Cpp/runtime/src/RuleContext.h

Line 135 in 1855d9a

bool operator == (const RuleContext &other) { return this == &other; } // Simple address comparison.

[xu20160924]

Have you solved that? I face the same problem.

[JoD]

Yes, just remove the line above (135 in Rulecontext.h) as it does nothing different from the virtual method it reimplements.