Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom flag settings #32

Open
3 tasks done
Woovie opened this issue May 28, 2023 · 1 comment
Open
3 tasks done

Allow for custom flag settings #32

Woovie opened this issue May 28, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Woovie
Copy link

Woovie commented May 28, 2023

Clear and concise description of the problem

I have customized my dev command to be vercel dev to ensure my Serverless Functions for Vercel are usable within this extension. When the command runs, you can see this error:

130 % vercel dev --port=4000
Vercel CLI 30.0.0
WARN! `--port` is deprecated, please use `--listen` instead
> Running Dev Command “vite --port $PORT”

  VITE v4.3.9  ready in 145 ms

  ➜  Local:   http://localhost:4000/
  ➜  Network: use --host to expose
  ➜  press h to show help
> Ready! Available at http://localhost:4000
WARN! `--port` is deprecated, please use `--listen` instead

Suggested solution

Allow users to specify custom flag names or a flag override field would be the ideal solution.

Alternative

Have a field that allows users to input their own flags and ignore the default port field? Not sure.

Additional context

It looks like --port is hardcoded at the moment:

command += ` --port=${ctx.port}`

Validations

@Woovie Woovie added the enhancement New feature or request label May 28, 2023
@Woovie
Copy link
Author

Woovie commented May 28, 2023

I think maybe having a dotfile configuration would also perhaps be nice so this can be a per-project setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant