Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Assign initial mesh method #5556

Merged
merged 7 commits into from
Dec 12, 2024
Merged

FEAT: Assign initial mesh method #5556

merged 7 commits into from
Dec 12, 2024

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Dec 10, 2024 •
edited
Loading

Description

Assign manual initial mesh settings

Issue linked

Close #5551

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Dec 10, 2024
@Samuelopez-ansys Samuelopez-ansys mentioned this pull request Dec 10, 2024
Closed
@Samuelopez-ansys Samuelopez-ansys changed the title Assign initial mesh method FEAT: Assign initial mesh method Dec 10, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.30%. Comparing base (23f68ca) to head (da01814).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5556      +/-   ##
==========================================
+ Coverage   85.29%   85.30%   +0.01%     
==========================================
  Files         151      151              
  Lines       60751    60778      +27     
==========================================
+ Hits        51817    51847      +30     
+ Misses       8934     8931       -3

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) December 11, 2024 15:11
SMoraisAnsys
SMoraisAnsys previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left multiple minor comments that should enhance readability.

src/ansys/aedt/core/modules/mesh.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/mesh.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/mesh.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/mesh.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/mesh.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/mesh.py Outdated Show resolved Hide resolved
tests/system/general/test_27_Maxwell2D.py Show resolved Hide resolved
@Samuelopez-ansys @SMoraisAnsys
Apply suggestions from code review
edfbb9f 
Co-authored-by: Sébastien Morais <[email protected]>
@Samuelopez-ansys
Copy link
Member Author

@SMoraisAnsys Thank you!

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) December 12, 2024 10:56
maxcapodi78
maxcapodi78 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 67d3abc into main Dec 12, 2024
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/issue_5551 branch December 12, 2024 19:01
svandenb-dev
svandenb-dev reviewed Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svandenb-dev svandenb-dev svandenb-dev left review comments

@maxcapodi78 maxcapodi78 maxcapodi78 approved these changes

@SMoraisAnsys SMoraisAnsys SMoraisAnsys left review comments

@Alberto-DM Alberto-DM Awaiting requested review from Alberto-DM

Assignees
No one assigned
Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hfss.mesh.assign_initial_mesh_manually() function for detailed mesh settings for the initial mesh.
4 participants
@Samuelopez-ansys @svandenb-dev @maxcapodi78 @SMoraisAnsys