Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHORE: Add template extension - get started #5538

Merged
merged 16 commits into from
Dec 12, 2024
Merged

CHORE: Add template extension - get started #5538

merged 16 commits into from
Dec 12, 2024

Conversation

gmalinve
Copy link
Contributor

@gmalinve gmalinve commented Dec 8, 2024

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov Codecov
Copy link

codecov bot commented Dec 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.29%. Comparing base (23f68ca) to head (af9b8f0).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5538   +/-   ##
=======================================
  Coverage   85.29%   85.29%           
=======================================
  Files         151      151           
  Lines       60751    60751           
=======================================
  Hits        51817    51817           
  Misses       8934     8934

@SMoraisAnsys
Copy link
Collaborator

@gmalinve This is a good idea as it will help a lot users to build their own extension. This is something I discussed with @kruglovIFX and planned to work on but glad you took the lead !

@gmalinve gmalinve self-assigned this Dec 9, 2024
@gmalinve gmalinve linked an issue Dec 9, 2024 that may be closed by this pull request
Add extension template to help users get started #5539
Closed
@gmalinve gmalinve marked this pull request as ready for review December 12, 2024 16:21
@Samuelopez-ansys Samuelopez-ansys merged commit 6a54da1 into main Dec 12, 2024
44 of 75 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the chore/extension_template branch December 12, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

@SMoraisAnsys SMoraisAnsys Awaiting requested review from SMoraisAnsys

Assignees

@gmalinve gmalinve

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add extension template to help users get started
3 participants
@gmalinve @SMoraisAnsys @Samuelopez-ansys