Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --timestamp option for build sub-command #237

Open
gzm55 opened this issue Nov 20, 2020 · 3 comments
Open

add --timestamp option for build sub-command #237

gzm55 opened this issue Nov 20, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@gzm55
Copy link

gzm55 commented Nov 20, 2020

For producing deterministic image, we need pass a timestamp to buildah commit command. This timestamp should be passed from ansible-bender build ... or via the playbook variables. For building a squashed image in ci, we could use the commit timestamp as the value of this option.

@TomasTomecek
Copy link
Collaborator

Hi, thanks for opening this issue. This is the first time I learnt about buildah commit --timestamp.

I'm wondering if the value should be auto-populated by default and configurable. What would be your preference?

@TomasTomecek TomasTomecek added the enhancement New feature or request label Jan 8, 2021
@gzm55
Copy link
Author

gzm55 commented Jan 8, 2021

if do not pass timestamp to buildah commit, it is auto-populated by buildah. So the new optional argument (as cli parameter of yaml parameter) can be easily transmitted to the underlying container engine.

@TomasTomecek
Copy link
Collaborator

oki, understood

I'll try to implement passing that argument then

@TomasTomecek TomasTomecek self-assigned this Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants