Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inventory plugin: adding the instance hostname field as inventory hostname #434

Open
DeLoWaN opened this issue Jun 24, 2021 · 0 comments · May be fixed by #438
Open

inventory plugin: adding the instance hostname field as inventory hostname #434

DeLoWaN opened this issue Jun 24, 2021 · 0 comments · May be fixed by #438

Comments

@DeLoWaN
Copy link

DeLoWaN commented Jun 24, 2021

SUMMARY

inventory plugin: adding the instance hostname field as inventory hostname

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

inventory_plugin

ADDITIONAL INFORMATION

I think it would be a great addition. In my setup I use the hostname field of the instance which allows me to use a full FQDN. I cannot use as-is the FQDN in the name field since it does not allow dots ".".

I tested my modification in my own repo, and it works. But I am concerned about how to handle the fact that the hostname field might be absent (it is not mandatory on GCP). I fallbacked on the name field.

I wanted to discuss it before sending a PR.

What do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant